Commit b04eea88 authored Jul 23, 2013 by Paul Moore Committed by Eric Paris Jul 25, 2013

selinux: fix problems in netnode when BUG() is compiled out



When the BUG() macro is disabled at compile time it can cause some
problems in the SELinux netnode code: invalid return codes and
uninitialized variables.  This patch fixes this by making sure we take
some corrective action after the BUG() macro.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>

parent b43e725d

security/selinux/netnode.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -166,6 +166,7 @@ static void sel_netnode_insert(struct sel_netnode *node)
		break;
		default:
		BUG();
		return;
		}

		/* we need to impose a limit on the growth of the hash table so check
		@@ -225,6 +226,7 @@ static int sel_netnode_sid_slow(void addr, u16 family, u32 sid)
		break;
		default:
		BUG();
		ret = -EINVAL;
		}
		if (ret != 0)
		goto out;