Commit afece1c6 authored Mar 14, 2009 by Ilpo Järvinen Committed by David S. Miller Mar 15, 2009

tcp: make sure xmit goal size never becomes zero



It's not too likely to happen, would basically require crafted
packets (must hit the max guard in tcp_bound_to_half_wnd()).
It seems that nothing that bad would happen as there's tcp_mems
and congestion window that prevent runaway at some point from
hurting all too much (I'm not that sure what all those zero
sized segments we would generate do though in write queue).
Preventing it regardless is certainly the best way to go.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2a3a041c

net/ipv4/tcp.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -689,7 +689,7 @@ static unsigned int tcp_xmit_size_goal(struct sock *sk, u32 mss_now,
	}		}
	}		}

	return xmit_size_goal;		return max(xmit_size_goal, mss_now);
	}		}

	static int tcp_send_mss(struct sock sk, int size_goal, int flags)		static int tcp_send_mss(struct sock sk, int size_goal, int flags)