Commit afe8ce9b authored Jul 18, 2013 by Rohit Vaswani Committed by Linus Walleij Jul 20, 2013

drivers: gpio: msm: Fix the error condition for reading ngpio



of_property_read_u32 return 0 on success. The check was using a ! to
return error. Fix the if condition.

Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Pankaj Jangra <jangra.pankaj9@gmail.com>
Cc: "Bird, Tim" <Tim.Bird@sonymobile.com>
Signed-off-by: David Brown <davidb@codeaurora.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 949eb1a4

drivers/gpio/gpio-msm-v2.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -378,7 +378,7 @@ static int msm_gpio_probe(struct platform_device *pdev)
		int ret, ngpio;
		struct resource *res;

		if (!of_property_read_u32(pdev->dev.of_node, "ngpio", &ngpio)) {
		if (of_property_read_u32(pdev->dev.of_node, "ngpio", &ngpio)) {
		dev_err(&pdev->dev, "%s: ngpio property missing\n", __func__);
		return -EINVAL;
		}