Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aec39680 authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd4: fix spurious 4.1 post-reboot failures 



In the NFSv4.1 case, this could cause a spurious "NFSD: failed to write
recovery record (err -17); please check that /var/lib/nfs/v4recovery
exists and is writable.

Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Reported-by: default avatarSteve Dickson <SteveD@redhat.com>
parent 2d3475c0

fs/nfsd/nfs4recover.c

+8 −1
Original line number Diff line number Diff line
@@ -144,8 +144,15 @@ nfsd4_create_clid_dir(struct nfs4_client *clp) 
		status = PTR_ERR(dentry);

		goto out_unlock;

	}

	status = -EEXIST;

	if (dentry->d_inode)

		/*

		 * In the 4.1 case, where we're called from

		 * reclaim_complete(), records from the previous reboot

		 * may still be left, so this is OK.

		 *

		 * In the 4.0 case, we should never get here; but we may

		 * as well be forgiving and just succeed silently.

		 */

		goto out_put;

	status = mnt_want_write(rec_file->f_path.mnt);

	if (status)