Commit ae9a3405 authored Apr 11, 2012 by Jesper Juhl Committed by Kalle Valo Apr 13, 2012

ath6kl: fix memory leak in ath6kl_fwlog_block_read()



If, in
drivers/net/wireless/ath/ath6kl/debug.c::ath6kl_fwlog_block_read(),
the call to wait_for_completion_interruptible() returns -ERESTARTSYS
then we'll return without freeing the (as yet unused) memory we
allocated for 'buf' - thus leaking it.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

parent 6146ca69

drivers/net/wireless/ath/ath6kl/debug.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -407,8 +407,10 @@ static ssize_t ath6kl_fwlog_block_read(struct file *file,

		ret = wait_for_completion_interruptible(
		&ar->debug.fwlog_completion);
		if (ret == -ERESTARTSYS)
		if (ret == -ERESTARTSYS) {
		vfree(buf);
		return ret;
		}

		spin_lock(&ar->debug.fwlog_queue.lock);
		}