Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae768d5f authored by Dan Carpenter's avatar Dan Carpenter Committed by Ohad Ben-Cohen
Browse files

remoteproc: snprintf() can return more than was printed 



snprintf() returns the number of characters which would have been
printed if there were enough space.  For example, on the first print if
we fill up the 28 character string then it would return a number more
than 30.  Use scnprintf() instead because that returns the actual number
of characters printed.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
parent ec4d02d9

drivers/remoteproc/remoteproc_debugfs.c

+2 −2
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ static ssize_t rproc_state_read(struct file *filp, char __user *userbuf, 


	state = rproc->state > RPROC_LAST ? RPROC_LAST : rproc->state;



	i = snprintf(buf, 30, "%.28s (%d)\n", rproc_state_string[state],

	i = scnprintf(buf, 30, "%.28s (%d)\n", rproc_state_string[state],

							rproc->state);



	return simple_read_from_buffer(userbuf, count, ppos, buf, i);
@@ -103,7 +103,7 @@ static ssize_t rproc_name_read(struct file *filp, char __user *userbuf, 
	char buf[100];

	int i;



	i = snprintf(buf, sizeof(buf), "%.98s\n", rproc->name);

	i = scnprintf(buf, sizeof(buf), "%.98s\n", rproc->name);



	return simple_read_from_buffer(userbuf, count, ppos, buf, i);

}