Commit ae6ff61e authored Jul 27, 2011 by Dan Carpenter Committed by Takashi Iwai Jul 27, 2011

ALSA: asihpi - off by one in asihpi_hpi_ioctl()



"adapter" is used as an array index in the adapters[] array so
the off by one would make us read past the end.

1c073b67 "ALSA: asihpi - Remove spurious adapter index check"
reverted Dan Rosenberg's check that would have prevented the
overflow here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 60a6a842

sound/pci/asihpi/hpioctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -183,7 +183,7 @@ long asihpi_hpi_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
		u32 adapter = hm->h.adapter_index;
		struct hpi_adapter *pa = &adapters[adapter];

		if ((adapter > HPI_MAX_ADAPTERS) \|\| (!pa->type)) {
		if ((adapter >= HPI_MAX_ADAPTERS) \|\| (!pa->type)) {
		hpi_init_response(&hr->r0, HPI_OBJ_ADAPTER,
		HPI_ADAPTER_OPEN,
		HPI_ERROR_BAD_ADAPTER_NUMBER);