Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae0b3950 authored by Sachin Bhayare's avatar Sachin Bhayare
Browse files

msm: mdss: Fix memory leak in MDP3 driver 



Memory leak was occurring in DMA buffer unmap path because skip_detach
flag was not initialized in mdp3_overlay_queue_buffer function.

Fix memory leak by initializing skip_detach in mdp3_overlay_queue_buffer
and mdp3_get_img function.

Change-Id: I84bf9f839b39abfabf51dc0b4d48e578f7c1667b
Signed-off-by: default avatarSachin Bhayare <sachin.bhayare@codeaurora.org>
parent ee833ce5

drivers/video/msm/mdss/mdp3.c

+1 −0
Original line number Diff line number Diff line
@@ -1903,6 +1903,7 @@ int mdp3_get_img(struct msmfb_data *img, struct mdp3_img_data *data, int client) 
			}



		data->mapped = true;

		data->skip_detach = false;

	}

done:

	if (!ret && (img->offset < data->len)) {

drivers/video/msm/mdss/mdp3_ctrl.c

+1 −0
Original line number Diff line number Diff line
@@ -1171,6 +1171,7 @@ static int mdp3_overlay_queue_buffer(struct msm_fb_data_type *mfd, 
	struct mdp3_img_data data;

	struct mdp3_dma *dma = mdp3_session->dma;



	memset(&data, 0, sizeof(struct mdp3_img_data));

	rc = mdp3_get_img(img, &data, MDP3_CLIENT_DMA_P);

	if (rc) {

		pr_err("fail to get overlay buffer\n");