Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad36b88e authored by Alan Cox's avatar Alan Cox Committed by Linus Torvalds
Browse files

tty: Fix an ircomm warning and note another bug 



Roel Kluin noted that line is unsigned so one test is unneccessary. Also
add a warning for another flaw I noticed while making this change.

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c847d47c

net/irda/ircomm/ircomm_tty.c

+3 −2
Original line number Diff line number Diff line
@@ -371,9 +371,8 @@ static int ircomm_tty_open(struct tty_struct *tty, struct file *filp) 
	IRDA_DEBUG(2, "%s()\n", __func__ );



	line = tty->index;

	if ((line < 0) || (line >= IRCOMM_TTY_PORTS)) {

	if (line >= IRCOMM_TTY_PORTS)

		return -ENODEV;

	}



	/* Check if instance already exists */

	self = hashbin_lock_find(ircomm_tty, line, NULL);
@@ -405,6 +404,8 @@ static int ircomm_tty_open(struct tty_struct *tty, struct file *filp) 
		 * Force TTY into raw mode by default which is usually what

		 * we want for IrCOMM and IrLPT. This way applications will

		 * not have to twiddle with printcap etc.

		 *

		 * Note this is completely usafe and doesn't work properly

		 */

		tty->termios->c_iflag = 0;

		tty->termios->c_oflag = 0;