Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad2f3d46 authored by Susheel Khiani's avatar Susheel Khiani
Browse files

iommu: msm: Remove IRQF_TRIGGER_RISING flag while registering interrupt 



While registering global interrupts we were
passing IRQF_TRIGGER_RISING flag to request
interrupt to be rising edge triggered. But it
seems for the particular interrupt line only
level triggered parameters are allowed. This is
because the interrupt distributor supports 1-N
software model for the particular interrupt
whereas we tried to program it to N-N model.

The issue was masked earlier as _setup_irq method
was not returning any error but just masking
the flags to permissible parameters. But with
update in _setup_irq function we are now seeing
error being reported saying failed to set
trigger mode. Fix this by not passing
TRIGGER_RISING flag to request_threaded_irq.

Change-Id: Iecf3f1663d2f8a5a70ddfc9b634398d2845c78e9
Signed-off-by: default avatarSusheel Khiani <skhiani@codeaurora.org>
parent b0af7638

drivers/iommu/msm_iommu_dev-v1.c

+3 −5
Original line number Diff line number Diff line 
/* Copyright (c) 2012-2015, The Linux Foundation. All rights reserved.

/* Copyright (c) 2012-2016, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -461,8 +461,7 @@ static int msm_iommu_probe(struct platform_device *pdev) 
		ret = devm_request_threaded_irq(&pdev->dev, global_cfg_irq,

				NULL,

				msm_iommu_global_fault_handler,

				IRQF_ONESHOT | IRQF_SHARED |

				IRQF_TRIGGER_RISING,

				IRQF_ONESHOT | IRQF_SHARED,

				"msm_iommu_global_cfg_irq", pdev);

		if (ret < 0)

			pr_err("Request Global CFG IRQ %d failed with ret=%d\n",
@@ -475,8 +474,7 @@ static int msm_iommu_probe(struct platform_device *pdev) 
		ret = devm_request_threaded_irq(&pdev->dev, global_client_irq,

				NULL,

				msm_iommu_global_fault_handler,

				IRQF_ONESHOT | IRQF_SHARED |

				IRQF_TRIGGER_RISING,

				IRQF_ONESHOT | IRQF_SHARED,

				"msm_iommu_global_client_irq", pdev);

		if (ret < 0)

			pr_err("Request Global Client IRQ %d failed with ret=%d\n",