Commit acf5921a authored Sep 16, 2015 by Praneeth Paladugu

msm: vidc: Avoid calling scale clocks from controls



V4L2 control framework acquires ctrls lock before
s_ctrl and g_ctrl. If driver calls scale clocks with
control, it internally calls g_ctrl and it leads to
deadlocks. Hence avoid calling scale clocks with control.
The clocks will be scaled with future ETB\FTB anyways.

Change-Id: I8bf62d18fca445b0c1239b15e510790cf2105a8e
Signed-off-by: Praneeth Paladugu <ppaladug@codeaurora.org>

parent 62b3314e

drivers/media/platform/msm/vidc/msm_vdec.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2373,7 +2373,6 @@ static int try_set_ctrl(struct msm_vidc_inst inst, struct v4l2_ctrl ctrl)
		break;
		}

		msm_comm_scale_clocks_and_bus(inst);
		break;
		case V4L2_CID_MPEG_VIDC_VIDEO_ALLOC_MODE_INPUT:
		if (ctrl->val == V4L2_MPEG_VIDC_VIDEO_DYNAMIC) {