Commit acc69639 authored Feb 18, 2015 by Johan Hovold Committed by Sasha Levin Mar 14, 2015

USB: serial: fix potential use-after-free after failed probe



commit 07fdfc5e9f1c966be8722e8fa927e5ea140df5ce upstream.

Fix return value in probe error path, which could end up returning
success (0) on errors. This could in turn lead to use-after-free or
double free (e.g. in port_remove) when the port device is removed.

Fixes: c706ebdf ("USB: usb-serial: call port_probe and port_remove
at the right times")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Greg Kroah-Hartman <greg@kroah.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent 2e52da5f

drivers/usb/serial/bus.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -75,7 +75,7 @@ static int usb_serial_device_probe(struct device *dev)
		retval = device_create_file(dev, &dev_attr_port_number);
		if (retval) {
		if (driver->port_remove)
		retval = driver->port_remove(port);
		driver->port_remove(port);
		goto exit_with_autopm;
		}