Commit acc1ccad authored Oct 03, 2013 by Laxman Dewangan Committed by Mark Brown Oct 07, 2013

regulator: palmas: get regulators node from parent node only



The device tree binding of Palmas regulator driver says as:

palmas_pmis {
	compatible = "ti,palmas-pmic";
	...
	regulators {
		...
	}
};

In this "regulators" subnode is expected to be part of parent node, not
the outside of parent node. Hence to get the regulator node, the correct
call is of_get_child_by_name() rather than of_find_node_by_name() which
actually searches the "regulators" node from the parent node to end of DTS
file.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@linaro.org>

parent d0175e7e

drivers/regulator/palmas-regulator.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -826,7 +826,7 @@ static void palmas_dt_to_pdata(struct device *dev,
		int idx, ret;

		node = of_node_get(node);
		regulators = of_find_node_by_name(node, "regulators");
		regulators = of_get_child_by_name(node, "regulators");
		if (!regulators) {
		dev_info(dev, "regulator node not found\n");
		return;