Commit ac6f7819 authored Apr 13, 2008 by Gerrit Renker Committed by David S. Miller Apr 13, 2008

[INET]: sk_reuse is valbool

sk_reuse is declared as "unsigned char", but is set as type valbool in net/core/sock.c.
There is no other place in net/ where sk->sk_reuse is set to a value > 1, so the test
"sk_reuse > 1" can not be true.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3654ea02

net/ipv4/inet_connection_sock.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -133,8 +133,6 @@ int inet_csk_get_port(struct sock *sk, unsigned short snum)
		goto tb_not_found;
		tb_found:
		if (!hlist_empty(&tb->owners)) {
		if (sk->sk_reuse > 1)
		goto success;
		if (tb->fastreuse > 0 &&
		sk->sk_reuse && sk->sk_state != TCP_LISTEN) {
		goto success;