Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ac16ca64 authored by Akinobu Mita's avatar Akinobu Mita Committed by David S. Miller
Browse files

[NET]: Fix kfifo_alloc() error check. 



The return value of kfifo_alloc() should be checked by IS_ERR().

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 753eab76

net/dccp/probe.c

+2 −0
Original line number Diff line number Diff line
@@ -160,6 +160,8 @@ static __init int dccpprobe_init(void) 
	init_waitqueue_head(&dccpw.wait);

	spin_lock_init(&dccpw.lock);

	dccpw.fifo = kfifo_alloc(bufsize, GFP_KERNEL, &dccpw.lock);

	if (IS_ERR(dccpw.fifo))

		return PTR_ERR(dccpw.fifo);



	if (!proc_net_fops_create(procname, S_IRUSR, &dccpprobe_fops))

		goto err0;

net/ipv4/tcp_probe.c

+2 −0
Original line number Diff line number Diff line
@@ -156,6 +156,8 @@ static __init int tcpprobe_init(void) 
	init_waitqueue_head(&tcpw.wait);

	spin_lock_init(&tcpw.lock);

	tcpw.fifo = kfifo_alloc(bufsize, GFP_KERNEL, &tcpw.lock);

	if (IS_ERR(tcpw.fifo))

		return PTR_ERR(tcpw.fifo);



	if (!proc_net_fops_create(procname, S_IRUSR, &tcpprobe_fops))

		goto err0;