Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab6dae82 authored by Andy Grover's avatar Andy Grover Committed by Nicholas Bellinger
Browse files

target: Fix sizeof in kmalloc for some default_groups arrays 



Allocating an array of pointers, not the objects themselves. These two
sites now match all the other sites.

Signed-off-by: default avatarAndy Grover <agrover@redhat.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 3f0ed57b

drivers/target/target_core_configfs.c

+1 −1
Original line number Diff line number Diff line
@@ -2937,7 +2937,7 @@ static int __init target_core_init_configfs(void) 
	 * and ALUA Logical Unit Group and Target Port Group infrastructure.

	 */

	target_cg = &subsys->su_group;

	target_cg->default_groups = kmalloc(sizeof(struct config_group) * 2,

	target_cg->default_groups = kmalloc(sizeof(struct config_group *) * 2,

				GFP_KERNEL);

	if (!target_cg->default_groups) {

		pr_err("Unable to allocate target_cg->default_groups\n");

drivers/target/target_core_fabric_configfs.c

+1 −1
Original line number Diff line number Diff line
@@ -906,7 +906,7 @@ static struct config_group *target_fabric_make_lun( 
	lun_cg->default_groups[1] = NULL;



	port_stat_grp = &lun->port_stat_grps.stat_group;

	port_stat_grp->default_groups =  kzalloc(sizeof(struct config_group) * 4,

	port_stat_grp->default_groups =  kzalloc(sizeof(struct config_group *) * 4,

				GFP_KERNEL);

	if (!port_stat_grp->default_groups) {

		pr_err("Unable to allocate port_stat_grp->default_groups\n");