Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ab0648e8 authored by Rajesh Borundia's avatar Rajesh Borundia Committed by David S. Miller
Browse files

qlcnic: Fix memory leak. 



o In case QLC_83XX_MBX_CMD_NO_WAIT command type the calling
  function does not free the memory as it does not wait for
  response. So free it when get a response from adapter after
  sending the command.

Signed-off-by: default avatarRajesh Borundia <rajesh.borundia@qlogic.com>
Signed-off-by: default avatarShahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2c97e9e2

drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c

+8 −1
Original line number Diff line number Diff line
@@ -1370,7 +1370,7 @@ static int qlcnic_sriov_issue_cmd(struct qlcnic_adapter *adapter, 


	rsp = qlcnic_sriov_alloc_bc_trans(&trans);

	if (rsp)

		return rsp;

		goto free_cmd;



	rsp = qlcnic_sriov_prepare_bc_hdr(trans, cmd, seq, QLC_BC_COMMAND);

	if (rsp)
@@ -1425,6 +1425,13 @@ err_out: 


cleanup_transaction:

	qlcnic_sriov_cleanup_transaction(trans);



free_cmd:

	if (cmd->type == QLC_83XX_MBX_CMD_NO_WAIT) {

		qlcnic_free_mbx_args(cmd);

		kfree(cmd);

	}



	return rsp;

}