Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9d5fb4a authored by Benet Clark's avatar Benet Clark
Browse files

msm: mdss: Fix false-positive postprocessing error logs 



For HDMI use cases where there are no PP blocks available, there
are currently error/warning logs explaining the same. Rather than
print an error, these use cases should be handled and a debug
log should be printed.

Change-Id: Ib416323b9816e9e7a723058faeb03c43da88f918
Signed-off-by: default avatarBenet Clark <benetc@codeaurora.org>
parent 1d6b7340

drivers/video/msm/mdss/mdss_mdp_pp.c

+10 −6
Original line number Diff line number Diff line
@@ -2075,7 +2075,7 @@ int mdss_mdp_pp_resume(struct msm_fb_data_type *mfd) 
	}



	if (!mdss_mdp_mfd_valid_dspp(mfd)) {

		pr_warn("PP not supported on display num %d hw config\n",

		pr_debug("PP not supported on display num %d hw config\n",

			mfd->index);

		return -EPERM;

	}
@@ -3103,7 +3103,7 @@ static int mdss_mdp_limited_lut_igc_config(struct msm_fb_data_type *mfd) 
		return -EINVAL;



	if (!mdss_mdp_mfd_valid_dspp(mfd)) {

		pr_warn("IGC not supported on display num %d hw configuration\n",

		pr_debug("IGC not supported on display num %d hw configuration\n",

			mfd->index);

		return 0;

	}
@@ -3532,7 +3532,7 @@ clock_off: 
			ret = pp_pgc_lut_cache_params(config, mdss_pp_res,

				((is_lm) ? LM : DSPP), dspp_num);

			if (ret) {

				pr_err("gamut set config failed ret %d\n",

				pr_err("pgc cache params failed, ret %d\n",

					ret);

				goto argc_config_exit;

			}
@@ -3678,7 +3678,7 @@ static int mdss_mdp_panel_default_dither_config(struct msm_fb_data_type *mfd, 
	struct mdp_dither_data_v1_7 dither_data;



	if (!mdss_mdp_mfd_valid_dspp(mfd)) {

		pr_warn("dither config not supported on display num %d\n",

		pr_debug("dither config not supported on display num %d\n",

			mfd->index);

		return 0;

	}
@@ -4861,7 +4861,7 @@ static int mdss_mdp_get_ad(struct msm_fb_data_type *mfd, 
	}



	if (!mdss_mdp_mfd_valid_ad(mfd)) {

		pr_warn("AD not supported on display num %d hw config\n",

		pr_debug("AD not supported on display num %d hw config\n",

			mfd->index);

		return -EPERM;

	}
@@ -6545,7 +6545,11 @@ static int pp_ad_shutdown_cleanup(struct msm_fb_data_type *mfd) 
		return 0;



	ret = mdss_mdp_get_ad(mfd, &ad);

	if (ret) {

	if (ret == -ENODEV || ret == -EPERM) {

		pr_debug("AD not supported on device, disp num %d\n",

			mfd->index);

		return 0;

	} else if (ret) {

		pr_err("failed to get ad_info ret %d\n", ret);

		return ret;

	}