Commit a997ab33 authored Jun 12, 2010 by Rafael J. Wysocki Committed by Len Brown Jun 11, 2010

ACPI / ACPICA: Do not attempt to disable GPE when installing handler



Commit 0f849d2c (ACPICA: Minimize
the differences between linux GPE code and ACPICA code base)
introduced a change attempting to disable a GPE before installing
a handler for it in acpi_install_gpe_handler() which was incorrect.
First, the GPE disabled by it is never enabled again (except during
resume) which leads to battery insert/remove events not being
reported on the Maxim Levitsky's machine.  Second, the disabled
GPE is still reported as enabled by the sysfs interface that only
checks its enable register's enable_for_run mask.

Revert this change for now, because it causes more damage to happen
than the bug it was supposed to fix.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reported-and-tested-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Len Brown <len.brown@intel.com>

parent 0f849d2c

drivers/acpi/acpica/evxface.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -719,13 +719,6 @@ acpi_install_gpe_handler(acpi_handle gpe_device,
		handler->context = context;
		handler->method_node = gpe_event_info->dispatch.method_node;

		/* Disable the GPE before installing the handler */

		status = acpi_ev_disable_gpe(gpe_event_info);
		if (ACPI_FAILURE (status)) {
		goto unlock_and_exit;
		}

		/* Install the handler */

		flags = acpi_os_acquire_lock(acpi_gbl_gpe_lock);