Commit a98f77bb authored Feb 07, 2012 by Russell King

ARM: omap: fix section mismatch warning for sdp3430_twl_gpio_setup()

WARNING: arch/arm/mach-omap2/built-in.o(.text+0xd0f0): Section mismatch in reference from the function sdp3430_twl_gpio_setup() to the function .init.text:omap2_hsmmc_init()
The function sdp3430_twl_gpio_setup() references
the function __init omap2_hsmmc_init().
This is often because sdp3430_twl_gpio_setup lacks a __init
annotation or the annotation of omap2_hsmmc_init is wrong.

sdp3430_twl_gpio_setup() is called via platform data from the
gpio-twl4030 module, which can be inserted and removed at runtime.
This makes sdp3430_twl_gpio_setup() callable at runtime, and prevents
it being marked with an __init annotation.

As it calls omap2_hsmmc_init() unconditionally, the only resolution to
this warning is to remove the __init markings from omap2_hsmmc_init()
and its called functions. This addresses the functions in hsmmc.c.

Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent e3958fe0

arch/arm/mach-omap2/hsmmc.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -293,7 +293,7 @@ static inline void omap_hsmmc_mux(struct omap_mmc_platform_data *mmc_controller,
		}
		}

		static int __init omap_hsmmc_pdata_init(struct omap2_hsmmc_info *c,
		static int omap_hsmmc_pdata_init(struct omap2_hsmmc_info *c,
		struct omap_mmc_platform_data *mmc)
		{
		char *hc_name;
		@@ -430,7 +430,7 @@ static int __init omap_hsmmc_pdata_init(struct omap2_hsmmc_info *c,

		#define MAX_OMAP_MMC_HWMOD_NAME_LEN 16

		void __init omap_init_hsmmc(struct omap2_hsmmc_info *hsmmcinfo, int ctrl_nr)
		void omap_init_hsmmc(struct omap2_hsmmc_info *hsmmcinfo, int ctrl_nr)
		{
		struct omap_hwmod *oh;
		struct platform_device *pdev;
		@@ -487,7 +487,7 @@ done:
		kfree(mmc_data);
		}

		void __init omap2_hsmmc_init(struct omap2_hsmmc_info *controllers)
		void omap2_hsmmc_init(struct omap2_hsmmc_info *controllers)
		{
		u32 reg;