Commit a91db621 authored Jan 31, 2016 by Konstantin Khlebnikov Committed by Sasha Levin Mar 22, 2016

ovl: copy new uid/gid into overlayfs runtime inode



[ Upstream commit b81de061fa59f17d2730aabb1b84419ef3913810 ]

Overlayfs must update uid/gid after chown, otherwise functions
like inode_owner_or_capable() will check user against stale uid.
Catched by xfstests generic/087, it chowns file and calls utimes.

Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
Signed-off-by: Miklos Szeredi <miklos@szeredi.hu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent c190fea9

fs/overlayfs/inode.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -53,6 +53,8 @@ int ovl_setattr(struct dentry dentry, struct iattr attr)
		if (upperdentry) {
		mutex_lock(&upperdentry->d_inode->i_mutex);
		err = notify_change(upperdentry, attr, NULL);
		if (!err)
		ovl_copyattr(upperdentry->d_inode, dentry->d_inode);
		mutex_unlock(&upperdentry->d_inode->i_mutex);
		} else {
		err = ovl_copy_up_last(dentry, attr, false);