Commit a88a477f authored Sep 24, 2009 by Breno Leitão Committed by Greg Kroah-Hartman Dec 11, 2009

jsm: IRQ handlers doesn't need to have IRQ_DISABLED enabled



Currently jsm is showing the following message when loaded:

IRQ 432/JSM: IRQF_DISABLED is not guaranteed on shared IRQs

It's because the request_irq() is called using IRQF_DISABLED
and IRQF_SHARED.
Actually there is no need to use IRQF_DISABLED in this driver.

Signed-off-by: Breno Leitão <leitao@linux.vnet.ibm.com>
Cc: Scott Kilau <scottk@digi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent d71cb81a

drivers/serial/jsm/jsm_driver.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -123,7 +123,7 @@ static int __devinit jsm_probe_one(struct pci_dev *pdev, const struct pci_device
		}

		rc = request_irq(brd->irq, brd->bd_ops->intr,
		IRQF_DISABLED\|IRQF_SHARED, "JSM", brd);
		IRQF_SHARED, "JSM", brd);
		if (rc) {
		printk(KERN_WARNING "Failed to hook IRQ %d\n",brd->irq);
		goto out_iounmap;