Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a752a8b9 authored by Nikolay Aleksandrov's avatar Nikolay Aleksandrov Committed by David S. Miller
Browse files

bonding: fix packets_per_slave showing



There's an issue when showing the value of packets_per_slave due to
using signed integer. The value may be < 0 and thus not put through
reciprocal_value() before showing. This patch makes it use unsigned
integer when showing it.

CC: Andy Gospodarek <andy@greyhouse.net>
CC: Jay Vosburgh <fubar@us.ibm.com>
CC: Veaceslav Falico <vfalico@redhat.com>
CC: David S. Miller <davem@davemloft.net>
Signed-off-by: default avatarNikolay Aleksandrov <nikolay@redhat.com>
Acked-by: default avatarVeaceslav Falico <vfalico@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b05004ad
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -1635,12 +1635,12 @@ static ssize_t bonding_show_packets_per_slave(struct device *d,
					      char *buf)
{
	struct bonding *bond = to_bond(d);
	int packets_per_slave = bond->params.packets_per_slave;
	unsigned int packets_per_slave = bond->params.packets_per_slave;

	if (packets_per_slave > 1)
		packets_per_slave = reciprocal_value(packets_per_slave);

	return sprintf(buf, "%d\n", packets_per_slave);
	return sprintf(buf, "%u\n", packets_per_slave);
}

static ssize_t bonding_store_packets_per_slave(struct device *d,