Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a6ed0608 authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

ASoC: Replace BUG() with WARN() 



BUG() used in the driver is just to spit the stack trace on buggy
points, not really needed to stop the whole operation.  For that
purpose, it'd be more convenient to use WARN() instead with more
error information.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 9a743400

sound/soc/soc-cache.c

+4 −2
Original line number Diff line number Diff line
@@ -39,7 +39,8 @@ static bool snd_soc_set_cache_val(void *base, unsigned int idx, 
		break;

	}

	default:

		BUG();

		WARN(1, "Invalid word_size %d\n", word_size);

		break;

	}

	return false;

}
@@ -60,7 +61,8 @@ static unsigned int snd_soc_get_cache_val(const void *base, unsigned int idx, 
		return cache[idx];

	}

	default:

		BUG();

		WARN(1, "Invalid word_size %d\n", word_size);

		break;

	}

	/* unreachable */

	return -1;

sound/soc/soc-dapm.c

+3 −3
Original line number Diff line number Diff line
@@ -1412,7 +1412,7 @@ static void dapm_seq_check_event(struct snd_soc_card *card, 
		power = 0;

		break;

	default:

		BUG();

		WARN(1, "Unknown event %d\n", event);

		return;

	}
@@ -2001,7 +2001,7 @@ static ssize_t dapm_bias_read_file(struct file *file, char __user *user_buf, 
		level = "Off\n";

		break;

	default:

		BUG();

		WARN(1, "Unknown bias_level %d\n", dapm->bias_level);

		level = "Unknown\n";

		break;

	}
@@ -3416,7 +3416,7 @@ static int snd_soc_dai_link_event(struct snd_soc_dapm_widget *w, 
		break;



	default:

		BUG();

		WARN(1, "Unknown event %d\n", event);

		return -EINVAL;

	}