Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a650031a authored by Akinobu Mita's avatar Akinobu Mita Committed by Pierre Ossman
Browse files

mmc_test: initialize mmc_test_lock statically



The mutex mmc_test_lock is initialized at every time mmc_test device
is probed. Probing another mmc_test device may break the mutex, if
the probe function is called while the mutex is locked.

This patch fixes it by statically initializing mmc_test_lock.

Signed-off-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: default avatarPierre Ossman <drzeus@drzeus.cx>
parent 9d4e98e9
Loading
Loading
Loading
Loading
+1 −3
Original line number Diff line number Diff line
@@ -1040,7 +1040,7 @@ static const struct mmc_test_case mmc_test_cases[] = {

};

static struct mutex mmc_test_lock;
static DEFINE_MUTEX(mmc_test_lock);

static void mmc_test_run(struct mmc_test_card *test, int testcase)
{
@@ -1171,8 +1171,6 @@ static int mmc_test_probe(struct mmc_card *card)
	if ((card->type != MMC_TYPE_MMC) && (card->type != MMC_TYPE_SD))
		return -ENODEV;

	mutex_init(&mmc_test_lock);

	ret = device_create_file(&card->dev, &dev_attr_test);
	if (ret)
		return ret;