Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a5f658b7 authored by Oleg Nesterov's avatar Oleg Nesterov
Browse files

uprobes: Don't return success if alloc_uprobe() fails 



If alloc_uprobe() fails uprobe_register() should return ENOMEM, not 0.

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
parent b64b9c93

kernel/events/uprobes.c

+3 −1
Original line number Diff line number Diff line
@@ -813,7 +813,9 @@ int uprobe_register(struct inode *inode, loff_t offset, struct uprobe_consumer * 
	mutex_lock(uprobes_hash(inode));

	uprobe = alloc_uprobe(inode, offset);



	if (uprobe && !consumer_add(uprobe, uc)) {

	if (!uprobe) {

		ret = -ENOMEM;

	} else if (!consumer_add(uprobe, uc)) {

		ret = __uprobe_register(uprobe);

		if (ret) {

			uprobe->consumers = NULL;