Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a519b26d authored by NeilBrown's avatar NeilBrown
Browse files

md: remove suspicious size_of()



When calling bioset_create we pass the size of the front_pad as
   sizeof(mddev)
which looks suspicious as mddev is a pointer and so it looks like a
common mistake where
   sizeof(*mddev)
was intended.
The size is actually correct as we want to store a pointer in the
front padding of the bios created by the bioset, so make the intent
more explicit by using
   sizeof(mddev_t *)

Reported-by: default avatarZdenek Kabelac <zdenek.kabelac@gmail.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 768e587e
Loading
Loading
Loading
Loading
+2 −1
Original line number Diff line number Diff line
@@ -4497,7 +4497,8 @@ int md_run(mddev_t *mddev)
	}

	if (mddev->bio_set == NULL)
		mddev->bio_set = bioset_create(BIO_POOL_SIZE, sizeof(mddev));
		mddev->bio_set = bioset_create(BIO_POOL_SIZE,
					       sizeof(mddev_t *));

	spin_lock(&pers_lock);
	pers = find_pers(mddev->level, mddev->clevel);