Commit a517b608 authored Mar 18, 2013 by Jeff Layton Committed by J. Bruce Fields Mar 18, 2013

nfsd: only unhash DRC entries that are in the hashtable



It's not safe to call hlist_del() on a newly initialized hlist_node.
That leads to a NULL pointer dereference. Only do that if the entry
is hashed.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent a937536b

fs/nfsd/nfscache.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -102,6 +102,7 @@ nfsd_reply_cache_free_locked(struct svc_cacherep *rp)
		{
		if (rp->c_type == RC_REPLBUFF)
		kfree(rp->c_replvec.iov_base);
		if (!hlist_unhashed(&rp->c_hash))
		hlist_del(&rp->c_hash);
		list_del(&rp->c_lru);
		--num_drc_entries;