Commit a4ed2d4c authored Jul 02, 2012 by Ben Hutchings

sfc: Use strlcpy() to copy ethtool stats names



Fix CID 113703 in the Coverity report on Linux.

ethtool stats names are limited to 32 bytes including a null
terminator.  Use strlcpy() to ensure that we will always include the
null terminator even if a source string becomes longer than this.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>

parent f7cbb163

drivers/net/ethernet/sfc/ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -453,7 +453,7 @@ static void efx_ethtool_get_strings(struct net_device *net_dev,
		switch (string_set) {
		case ETH_SS_STATS:
		for (i = 0; i < EFX_ETHTOOL_NUM_STATS; i++)
		strncpy(ethtool_strings[i].name,
		strlcpy(ethtool_strings[i].name,
		efx_ethtool_stats[i].name,
		sizeof(ethtool_strings[i].name));
		break;