Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a450a685 authored by Zi Shen Lim's avatar Zi Shen Lim Committed by David S. Miller
Browse files

smc91x: improve definition of debug macros 



Redefine some macros that were conditioned upon SMC_DEBUG level.

By allowing compiler to verify parameters used by these macros
unconditionally, we can flag compilation failures.

Compiler will still optimize out the unused code path depending on
SMC_DEBUG, so this is a net gain.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarZi Shen Lim <zlim.lnx@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 83d5b7ef

drivers/net/ethernet/smsc/smc91x.c

+12 −11
Original line number Diff line number Diff line
@@ -147,18 +147,19 @@ MODULE_ALIAS("platform:smc91x"); 
 */

#define MII_DELAY		1



#if SMC_DEBUG > 0

#define DBG(n, dev, args...)				\

#define DBG(n, dev, fmt, ...)					\

	do {							\

		if (SMC_DEBUG >= (n))				\

			netdev_dbg(dev, args);		\

			netdev_dbg(dev, fmt, ##__VA_ARGS__);	\

	} while (0)



#define PRINTK(dev, args...)   netdev_info(dev, args)

#else

#define DBG(n, dev, args...)   do { } while (0)

#define PRINTK(dev, args...)   netdev_dbg(dev, args)

#endif

#define PRINTK(dev, fmt, ...)					\

	do {							\

		if (SMC_DEBUG > 0)				\

			netdev_info(dev, fmt, ##__VA_ARGS__);	\

		else						\

			netdev_dbg(dev, fmt, ##__VA_ARGS__);	\

	} while (0)



#if SMC_DEBUG > 3

static void PRINT_PKT(u_char *buf, int length)
@@ -191,7 +192,7 @@ static void PRINT_PKT(u_char *buf, int length) 
	pr_cont("\n");

}

#else

#define PRINT_PKT(x...)  do { } while (0)

static inline void PRINT_PKT(u_char *buf, int length) { }

#endif