Commit a4469a42 authored Nov 15, 2013 by Wei Yongjun Committed by Mark Brown Nov 15, 2013

spi: mpc512x: fix reference leak to master in mpc512x_psc_spi_do_remove()



Once a spi_master_get() call succeeds, we need an additional
spi_master_put() call to free the memory, otherwise we will
leak a reference to master. Fix by removing the unnecessary
spi_master_get() call.

Fixes: eaa24297 ('spi: mpc512x: use devm_spi_register_master()')
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Mark Brown <broonie@linaro.org>

parent 82f85cf9

drivers/spi/spi-mpc512x-psc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -556,7 +556,7 @@ free_master:

		static int mpc512x_psc_spi_do_remove(struct device *dev)
		{
		struct spi_master *master = spi_master_get(dev_get_drvdata(dev));
		struct spi_master *master = dev_get_drvdata(dev);
		struct mpc512x_psc_spi *mps = spi_master_get_devdata(master);

		clk_disable_unprepare(mps->clk_mclk);