Commit a3f99f8b authored Dec 29, 2006 by Akinobu Mita Committed by Linus Torvalds Dec 30, 2006

[PATCH] module: fix mod_sysfs_setup() return value



mod_sysfs_setup() doesn't return error when kobject_add_dir() failed.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 96ceeaf4

kernel/module.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1132,8 +1132,10 @@ static int mod_sysfs_setup(struct module *mod,
		goto out;

		mod->drivers_dir = kobject_add_dir(&mod->mkobj.kobj, "drivers");
		if (!mod->drivers_dir)
		if (!mod->drivers_dir) {
		err = -ENOMEM;
		goto out_unreg;
		}

		err = module_param_sysfs_setup(mod, kparam, num_params);
		if (err)