Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a21b0e49 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

hwmon: (asus_atk0110) fix uninitialized data access 




[ Upstream commit a2125d02443e9a4e68bcfd9f8004fa23239e8329 ]

The latest gcc-7 snapshot adds a warning to point out that when
atk_read_value_old or atk_read_value_new fails, we copy
uninitialized data into sensor->cached_value:

drivers/hwmon/asus_atk0110.c: In function 'atk_input_show':
drivers/hwmon/asus_atk0110.c:651:26: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Adding an error check avoids this. All versions of the driver
are affected.

Fixes: 2c03d07a ("hwmon: Add Asus ATK0110 support")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarLuca Tettamanti <kronos.it@gmail.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7593d5f9

drivers/hwmon/asus_atk0110.c

+3 −0
Original line number Diff line number Diff line
@@ -646,6 +646,9 @@ static int atk_read_value(struct atk_sensor_data *sensor, u64 *value) 
		else

			err = atk_read_value_new(sensor, value);



		if (err)

			return err;



		sensor->is_valid = true;

		sensor->last_updated = jiffies;

		sensor->cached_value = *value;