Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1dcb662 authored by Jarek Poplawski's avatar Jarek Poplawski Committed by David S. Miller
Browse files

pkt_sched: gen_estimator: Fix signed integers right-shifts. 



Right-shifts of signed integers are implementation-defined so unportable.

With feedback from: Eric Dumazet <dada1@cosmosbay.com>

Signed-off-by: default avatarJarek Poplawski <jarkao2@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dfa9264f

net/core/gen_estimator.c

+2 −2
Original line number Diff line number Diff line
@@ -128,12 +128,12 @@ static void est_timer(unsigned long arg) 
		npackets = e->bstats->packets;

		brate = (nbytes - e->last_bytes)<<(7 - idx);

		e->last_bytes = nbytes;

		e->avbps += ((s64)(brate - e->avbps)) >> e->ewma_log;

		e->avbps += (brate >> e->ewma_log) - (e->avbps >> e->ewma_log);

		e->rate_est->bps = (e->avbps+0xF)>>5;



		rate = (npackets - e->last_packets)<<(12 - idx);

		e->last_packets = npackets;

		e->avpps += ((long)rate - (long)e->avpps) >> e->ewma_log;

		e->avpps += (rate >> e->ewma_log) - (e->avpps >> e->ewma_log);

		e->rate_est->pps = (e->avpps+0x1FF)>>10;

skip:

		read_unlock(&est_lock);