Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a158906d authored by Eli Cohen's avatar Eli Cohen Committed by David S. Miller
Browse files

net/mlx5_core: Fix race in create EQ 



After the EQ is created, it can possibly generate interrupts and the interrupt
handler is referencing eq->dev. It is therefore required to set eq->dev before
calling request_irq() so if an event is generated before request_irq() returns,
we will have a valid eq->dev field.

Signed-off-by: default avatarEli Cohen <eli@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b31f65fb

drivers/net/ethernet/mellanox/mlx5/core/eq.c

+3 −4
Original line number Diff line number Diff line
@@ -374,15 +374,14 @@ int mlx5_create_map_eq(struct mlx5_core_dev *dev, struct mlx5_eq *eq, u8 vecidx, 
	snprintf(eq->name, MLX5_MAX_EQ_NAME, "%s@pci:%s",

		 name, pci_name(dev->pdev));

	eq->eqn = out.eq_number;

	eq->irqn = vecidx;

	eq->dev = dev;

	eq->doorbell = uar->map + MLX5_EQ_DOORBEL_OFFSET;

	err = request_irq(table->msix_arr[vecidx].vector, mlx5_msix_handler, 0,

			  eq->name, eq);

	if (err)

		goto err_eq;



	eq->irqn = vecidx;

	eq->dev = dev;

	eq->doorbell = uar->map + MLX5_EQ_DOORBEL_OFFSET;



	err = mlx5_debug_eq_add(dev, eq);

	if (err)

		goto err_irq;