Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a14c44d8 authored by Tomas Winkler's avatar Tomas Winkler Committed by Greg Kroah-Hartman
Browse files

mei: mei_cl_unlink: no need to loop over dev list 



we can call list_del_init regardless the client is
linked or not it is always properly initialized

Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 136698e5

drivers/misc/mei/client.c

+4 −9
Original line number Diff line number Diff line
@@ -318,7 +318,6 @@ int mei_cl_link(struct mei_cl *cl, int id) 
int mei_cl_unlink(struct mei_cl *cl)

{

	struct mei_device *dev;

	struct mei_cl *pos, *next;



	/* don't shout on error exit path */

	if (!cl)
@@ -330,14 +329,10 @@ int mei_cl_unlink(struct mei_cl *cl) 


	dev = cl->dev;



	list_for_each_entry_safe(pos, next, &dev->file_list, link) {

		if (cl->host_client_id == pos->host_client_id) {

			cl_dbg(dev, cl, "remove host client = %d, ME client = %d\n",

				pos->host_client_id, pos->me_client_id);

			list_del_init(&pos->link);

			break;

		}

	}

	cl_dbg(dev, cl, "unlink client");



	list_del_init(&cl->link);



	return 0;

}