Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a09ba13e authored Apr 16, 2012 by Asai Thambi S P Committed by Jens Axboe May 11, 2012

mtip32xx: release the semaphore on an error path



Release the semaphore in an error path in mtip_hw_get_scatterlist(). This
fixes the smatch warning inconsistent returns.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent d88a440e

drivers/block/mtip32xx/mtip32xx.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2510,8 +2510,10 @@ static struct scatterlist mtip_hw_get_scatterlist(struct driver_data dd,
	up(&dd->port->cmd_slot);		up(&dd->port->cmd_slot);
	return NULL;		return NULL;
	}		}
	if (unlikely(*tag < 0))		if (unlikely(*tag < 0)) {
			up(&dd->port->cmd_slot);
	return NULL;		return NULL;
			}

	return dd->port->commands[*tag].sg;		return dd->port->commands[*tag].sg;
	}		}