Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a06631cb authored by Stephen Hemminger's avatar Stephen Hemminger Committed by Jeff Garzik
Browse files

[PATCH] skge: don't allow transmit ring to be too small 



The driver will get stuck (permanent transmit timeout), if the transmit
ring size is set too small.  It needs to have enough ring elements to
hold one maximum size transmit.

Signed-off-by: default avatarStephen Hemminger <shemminger@osdl.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 20e777a2

drivers/net/skge.c

+1 −1
Original line number Diff line number Diff line
@@ -401,7 +401,7 @@ static int skge_set_ring_param(struct net_device *dev, 
	int err;



	if (p->rx_pending == 0 || p->rx_pending > MAX_RX_RING_SIZE ||

	    p->tx_pending == 0 || p->tx_pending > MAX_TX_RING_SIZE)

	    p->tx_pending < MAX_SKB_FRAGS+1 || p->tx_pending > MAX_TX_RING_SIZE)

		return -EINVAL;



	skge->rx_ring.count = p->rx_pending;