Commit 9fdce099 authored Oct 30, 2009 by Eric W. Biederman Committed by David S. Miller Nov 01, 2009

veth: Fix unregister_netdevice_queue for veth



I tested the recent unregister many changes and got a weird,
nasty and seemingly unrelasted kernel oops. Changing
unregister_netdevice_queue to use list_move_tail fixes
the problem for me.

ip link add type veth
rmmod veth

ls /sys/class/net/
showed one of the veth devices still present.

A subsequent ip link oopsed the box.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 72c9528b

net/core/dev.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -5258,6 +5258,7 @@ struct net_device alloc_netdev_mq(int sizeof_priv, const char name,
		netdev_init_queues(dev);

		INIT_LIST_HEAD(&dev->napi_list);
		INIT_LIST_HEAD(&dev->unreg_list);
		dev->priv_flags = IFF_XMIT_DST_RELEASE;
		setup(dev);
		strcpy(dev->name, name);
		@@ -5339,7 +5340,7 @@ void unregister_netdevice_queue(struct net_device dev, struct list_head head)
		ASSERT_RTNL();

		if (head) {
		list_add_tail(&dev->unreg_list, head);
		list_move_tail(&dev->unreg_list, head);
		} else {
		rollback_registered(dev);
		/* Finish processing unregister after unlock */