Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9fc1b9ef authored by Linux Build Service Account's avatar Linux Build Service Account Committed by Gerrit - the friendly Code Review server
Browse files

Merge "Revert "ANDROID: fs: FS tracepoints to track IO.""

parents e451d7f8 ba81f704
Loading
Loading
Loading
Loading
+0 −6
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@
#include "ext4.h"
#include "xattr.h"
#include "truncate.h"
#include <trace/events/android_fs.h>

#define EXT4_XATTR_SYSTEM_DATA	"data"
#define EXT4_MIN_INLINE_DATA_SIZE	((sizeof(__le32) * EXT4_N_BLOCKS))
@@ -502,9 +501,6 @@ int ext4_readpage_inline(struct inode *inode, struct page *page)
		return -EAGAIN;
	}

	trace_android_fs_dataread_start(inode, page_offset(page), PAGE_SIZE,
					current->pid, current->comm);

	/*
	 * Current inline data can only exist in the 1st page,
	 * So for all the other pages, just set them uptodate.
@@ -516,8 +512,6 @@ int ext4_readpage_inline(struct inode *inode, struct page *page)
		SetPageUptodate(page);
	}

	trace_android_fs_dataread_end(inode, page_offset(page), PAGE_SIZE);

	up_read(&EXT4_I(inode)->xattr_sem);

	unlock_page(page);
+0 −23
Original line number Diff line number Diff line
@@ -46,7 +46,6 @@
#include "truncate.h"

#include <trace/events/ext4.h>
#include <trace/events/android_fs.h>

#define MPAGE_DA_EXTENT_TAIL 0x01

@@ -981,8 +980,6 @@ static int ext4_write_begin(struct file *file, struct address_space *mapping,
	pgoff_t index;
	unsigned from, to;

	trace_android_fs_datawrite_start(inode, pos, len,
					 current->pid, current->comm);
	trace_ext4_write_begin(inode, pos, len, flags);
	/*
	 * Reserve one block more for addition to orphan list in case
@@ -1118,7 +1115,6 @@ static int ext4_write_end(struct file *file,
	int ret = 0, ret2;
	int i_size_changed = 0;

	trace_android_fs_datawrite_end(inode, pos, len);
	trace_ext4_write_end(inode, pos, len, copied);
	if (ext4_test_inode_state(inode, EXT4_STATE_ORDERED_MODE)) {
		ret = ext4_jbd2_file_inode(handle, inode);
@@ -1192,7 +1188,6 @@ static int ext4_journalled_write_end(struct file *file,
	unsigned from, to;
	int size_changed = 0;

	trace_android_fs_datawrite_end(inode, pos, len);
	trace_ext4_journalled_write_end(inode, pos, len, copied);
	from = pos & (PAGE_CACHE_SIZE - 1);
	to = from + len;
@@ -2687,8 +2682,6 @@ static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
					len, flags, pagep, fsdata);
	}
	*fsdata = (void *)0;
	trace_android_fs_datawrite_start(inode, pos, len,
					 current->pid, current->comm);
	trace_ext4_da_write_begin(inode, pos, len, flags);

	if (ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA)) {
@@ -2807,7 +2800,6 @@ static int ext4_da_write_end(struct file *file,
		return ext4_write_end(file, mapping, pos,
				      len, copied, page, fsdata);

	trace_android_fs_datawrite_end(inode, pos, len);
	trace_ext4_da_write_end(inode, pos, len, copied);
	start = pos & (PAGE_CACHE_SIZE - 1);
	end = start + copied - 1;
@@ -3284,27 +3276,12 @@ static ssize_t ext4_direct_IO(int rw, struct kiocb *iocb,
	if (ext4_has_inline_data(inode))
		return 0;

	if (trace_android_fs_dataread_start_enabled() && (rw == READ))
		trace_android_fs_dataread_start(inode, offset, count,
						current->pid,
						current->comm);
	if (trace_android_fs_datawrite_start_enabled() && (rw == WRITE))
		trace_android_fs_datawrite_start(inode, offset, count,
						 current->pid,
						 current->comm);

	trace_ext4_direct_IO_enter(inode, offset, count, rw);
	if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
		ret = ext4_ext_direct_IO(rw, iocb, iter, offset);
	else
		ret = ext4_ind_direct_IO(rw, iocb, iter, offset);
	trace_ext4_direct_IO_exit(inode, offset, count, rw, ret);

	if (trace_android_fs_dataread_start_enabled() && (rw == READ))
		trace_android_fs_dataread_end(inode, offset, count);
	if (trace_android_fs_datawrite_start_enabled() && (rw == WRITE))
		trace_android_fs_datawrite_end(inode, offset, count);

	return ret;
}

+4 −37
Original line number Diff line number Diff line
@@ -45,7 +45,6 @@
#include <linux/cleancache.h>

#include "ext4.h"
#include <trace/events/android_fs.h>

/*
 * Call ext4_decrypt on every single page, reusing the encryption
@@ -87,17 +86,6 @@ static inline bool ext4_bio_encrypted(struct bio *bio)
#endif
}

static void
ext4_trace_read_completion(struct bio *bio, int err)
{
	struct page *first_page = bio->bi_io_vec[0].bv_page;

	if (first_page != NULL)
		trace_android_fs_dataread_end(first_page->mapping->host,
					      page_offset(first_page),
					      bio->bi_iter.bi_size);
}

/*
 * I/O completion handler for multipage BIOs.
 *
@@ -115,9 +103,6 @@ static void mpage_end_io(struct bio *bio, int err)
	struct bio_vec *bv;
	int i;

	if (trace_android_fs_dataread_start_enabled())
		ext4_trace_read_completion(bio, err);

	if (ext4_bio_encrypted(bio)) {
		struct ext4_crypto_ctx *ctx = bio->bi_private;

@@ -145,24 +130,6 @@ static void mpage_end_io(struct bio *bio, int err)
	bio_put(bio);
}

static void
ext4_submit_bio_read(struct bio *bio)
{
	if (trace_android_fs_dataread_start_enabled()) {
		struct page *first_page = bio->bi_io_vec[0].bv_page;

		if (first_page != NULL) {
			trace_android_fs_dataread_start(
				first_page->mapping->host,
				page_offset(first_page),
				bio->bi_iter.bi_size,
				current->pid,
				current->comm);
		}
	}
	submit_bio(READ, bio);
}

int ext4_mpage_readpages(struct address_space *mapping,
			 struct list_head *pages, struct page *page,
			 unsigned nr_pages)
@@ -304,7 +271,7 @@ int ext4_mpage_readpages(struct address_space *mapping,
		 */
		if (bio && (last_block_in_bio != blocks[0] - 1)) {
		submit_and_realloc:
			ext4_submit_bio_read(bio);
			submit_bio(READ, bio);
			bio = NULL;
		}
		if (bio == NULL) {
@@ -336,14 +303,14 @@ int ext4_mpage_readpages(struct address_space *mapping,
		if (((map.m_flags & EXT4_MAP_BOUNDARY) &&
		     (relative_block == map.m_len)) ||
		    (first_hole != blocks_per_page)) {
			ext4_submit_bio_read(bio);
			submit_bio(READ, bio);
			bio = NULL;
		} else
			last_block_in_bio = blocks[blocks_per_page - 1];
		goto next_page;
	confused:
		if (bio) {
			ext4_submit_bio_read(bio);
			submit_bio(READ, bio);
			bio = NULL;
		}
		if (!PageUptodate(page))
@@ -356,6 +323,6 @@ int ext4_mpage_readpages(struct address_space *mapping,
	}
	BUG_ON(pages && !list_empty(pages));
	if (bio)
		ext4_submit_bio_read(bio);
		submit_bio(READ, bio);
	return 0;
}
+0 −17
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@
#include "node.h"
#include "segment.h"
#include <trace/events/f2fs.h>
#include <trace/events/android_fs.h>

static void f2fs_read_end_io(struct bio *bio, int err)
{
@@ -966,8 +965,6 @@ static int f2fs_write_begin(struct file *file, struct address_space *mapping,
	struct dnode_of_data dn;
	int err = 0;

	trace_android_fs_datawrite_start(inode, pos, len,
					 current->pid, current->comm);
	trace_f2fs_write_begin(inode, pos, len, flags);

	f2fs_balance_fs(sbi);
@@ -1060,7 +1057,6 @@ static int f2fs_write_end(struct file *file,
{
	struct inode *inode = page->mapping->host;

	trace_android_fs_datawrite_end(inode, pos, len);
	trace_f2fs_write_end(inode, pos, len, copied);

	if (f2fs_is_atomic_file(inode) || f2fs_is_volatile_file(inode))
@@ -1111,14 +1107,6 @@ static ssize_t f2fs_direct_IO(int rw, struct kiocb *iocb,
	if (check_direct_IO(inode, rw, iter, offset))
		return 0;

	if (trace_android_fs_dataread_start_enabled() && (rw == READ))
		trace_android_fs_dataread_start(inode, offset,
						count, current->pid,
						current->comm);
	if (trace_android_fs_datawrite_start_enabled() && (rw == WRITE))
		trace_android_fs_datawrite_start(inode, offset, count,
						 current->pid, current->comm);

	trace_f2fs_direct_IO_enter(inode, offset, count, rw);

	err = blockdev_direct_IO(rw, iocb, inode, iter, offset, get_data_block);
@@ -1127,11 +1115,6 @@ static ssize_t f2fs_direct_IO(int rw, struct kiocb *iocb,

	trace_f2fs_direct_IO_exit(inode, offset, count, rw, err);

	if (trace_android_fs_dataread_start_enabled() && (rw == READ))
		trace_android_fs_dataread_end(inode, offset, count);
	if (trace_android_fs_datawrite_start_enabled() && (rw == WRITE))
		trace_android_fs_datawrite_end(inode, offset, count);

	return err;
}

+0 −8
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@
#include <linux/f2fs_fs.h>

#include "f2fs.h"
#include <trace/events/android_fs.h>

bool f2fs_may_inline(struct inode *inode)
{
@@ -41,10 +40,6 @@ int f2fs_read_inline_data(struct inode *inode, struct page *page)
	struct page *ipage;
	void *src_addr, *dst_addr;

	trace_android_fs_dataread_start(inode, page_offset(page),
					PAGE_SIZE, current->pid,
					current->comm);

	if (page->index) {
		zero_user_segment(page, 0, PAGE_CACHE_SIZE);
		goto out;
@@ -52,8 +47,6 @@ int f2fs_read_inline_data(struct inode *inode, struct page *page)

	ipage = get_node_page(F2FS_I_SB(inode), inode->i_ino);
	if (IS_ERR(ipage)) {
		trace_android_fs_dataread_end(inode, page_offset(page),
					      PAGE_SIZE);
		unlock_page(page);
		return PTR_ERR(ipage);
	}
@@ -68,7 +61,6 @@ int f2fs_read_inline_data(struct inode *inode, struct page *page)
	f2fs_put_page(ipage, 1);

out:
	trace_android_fs_dataread_end(inode, page_offset(page), PAGE_SIZE);
	SetPageUptodate(page);
	unlock_page(page);

Loading