Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f8cb7be authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

scsi: sg: off by one in sg_ioctl() 



commit bd46fc406b30d1db1aff8dabaff8d18bb423fdcf upstream.

If "val" is SG_MAX_QUEUE then we are one element beyond the end of the
"rinfo" array so the > should be >=.

Fixes: 109bade9c625 ("scsi: sg: use standard lists for sg_requests")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarDouglas Gilbert <dgilbert@interlog.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a19e985c

drivers/scsi/sg.c

+1 −1
Original line number Diff line number Diff line
@@ -1056,7 +1056,7 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg) 
			read_lock_irqsave(&sfp->rq_list_lock, iflags);

			val = 0;

			list_for_each_entry(srp, &sfp->rq_list, entry) {

				if (val > SG_MAX_QUEUE)

				if (val >= SG_MAX_QUEUE)

					break;

				memset(&rinfo[val], 0, SZ_SG_REQ_INFO);

				rinfo[val].req_state = srp->done + 1;