Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9df03abe authored by Marcin Slusarz's avatar Marcin Slusarz Committed by Arnaldo Carvalho de Melo
Browse files

perf lock: Fix sorting by wait_min 



If lock was uncontended, wait_time_min == ULLONG_MAX, so we need to
handle this case differently to show high wait times first

Acked-by: default avatarHitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20110222174715.GC9687@joi.lan>
Signed-off-by: default avatarMarcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 58d406ed

tools/perf/builtin-lock.c

+12 −1
Original line number Diff line number Diff line
@@ -202,9 +202,20 @@ static struct thread_stat *thread_stat_findnew_first(u32 tid) 
SINGLE_KEY(nr_acquired)

SINGLE_KEY(nr_contended)

SINGLE_KEY(wait_time_total)

SINGLE_KEY(wait_time_min)

SINGLE_KEY(wait_time_max)



static int lock_stat_key_wait_time_min(struct lock_stat *one,

					struct lock_stat *two)

{

	u64 s1 = one->wait_time_min;

	u64 s2 = two->wait_time_min;

	if (s1 == ULLONG_MAX)

		s1 = 0;

	if (s2 == ULLONG_MAX)

		s2 = 0;

	return s1 > s2;

}



struct lock_key {

	/*

	 * name: the value for specify by user