Commit 9d02b426 authored Mar 15, 2011 by Michal Sojka Committed by Greg Kroah-Hartman Mar 23, 2011

USB: Do not pass negative length to snoop_urb()



When `echo Y > /sys/module/usbcore/parameters/usbfs_snoop` and
usb_control_msg() returns error, a lot of kernel memory is dumped to dmesg
until unhandled kernel paging request occurs.

Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 4bbba111

drivers/usb/core/devio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -802,7 +802,7 @@ static int proc_control(struct dev_state ps, void __user arg)
		tbuf, ctrl.wLength, tmo);
		usb_lock_device(dev);
		snoop_urb(dev, NULL, pipe, max(i, 0), min(i, 0), COMPLETE,
		tbuf, i);
		tbuf, max(i, 0));
		if ((i > 0) && ctrl.wLength) {
		if (copy_to_user(ctrl.data, tbuf, i)) {
		free_page((unsigned long)tbuf);