Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cd00941 authored by Ricardo Ribalda Delgado's avatar Ricardo Ribalda Delgado Committed by Arnaldo Carvalho de Melo
Browse files

perf symbols: Support for Openembedded/Yocto -dbg packages 



On OpenEmbedded the symbol files are located under a .debug folder on
the same folder as the binary file.

This patch adds support for such files.

Without this patch on perf top you can see:

no symbols found in /usr/lib/gstreamer-1.0/libtheoraenc.so.1.1.2, maybe
install a debug package?

84.56%  libtheoraenc.so.1.1.2       [.] 0x000000000000b346

With this patch symbols are shown:

19.06%  libtheoraenc.so.1.1.2       [.] oc_int_frag_satd_thresh_mmxext
9.76%   libtheoraenc.so.1.1.2       [.] oc_analyze_mb_mode_luma
5.58%   libtheoraenc.so.1.1.2       [.] oc_qii_state_advance
4.84%   libtheoraenc.so.1.1.2       [.] oc_enc_tokenize_ac
...

Signed-off-by: default avatarRicardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Acked-by: default avatarIngo Molnar <mingo@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Waiman Long <Waiman.Long@hp.com>
Link: http://lkml.kernel.org/r/1379512574-25912-1-git-send-email-ricardo.ribalda@gmail.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 6e0dc374

tools/perf/util/dso.c

+36 −13
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@ char dso__symtab_origin(const struct dso *dso) 
		[DSO_BINARY_TYPE__BUILD_ID_CACHE]		= 'B',

		[DSO_BINARY_TYPE__FEDORA_DEBUGINFO]		= 'f',

		[DSO_BINARY_TYPE__UBUNTU_DEBUGINFO]		= 'u',

		[DSO_BINARY_TYPE__OPENEMBEDDED_DEBUGINFO]	= 'o',

		[DSO_BINARY_TYPE__BUILDID_DEBUGINFO]		= 'b',

		[DSO_BINARY_TYPE__SYSTEM_PATH_DSO]		= 'd',

		[DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE]		= 'K',
@@ -64,6 +65,28 @@ int dso__binary_type_file(struct dso *dso, enum dso_binary_type type, 
			 symbol_conf.symfs, dso->long_name);

		break;



	case DSO_BINARY_TYPE__OPENEMBEDDED_DEBUGINFO:

	{

		char *last_slash;

		size_t len;

		size_t dir_size;



		last_slash = dso->long_name + dso->long_name_len;

		while (last_slash != dso->long_name && *last_slash != '/')

			last_slash--;



		len = scnprintf(file, size, "%s", symbol_conf.symfs);

		dir_size = last_slash - dso->long_name + 2;

		if (dir_size > (size - len)) {

			ret = -1;

			break;

		}

		len += scnprintf(file + len, dir_size, "%s",  dso->long_name);

		len += scnprintf(file + len , size - len, ".debug%s",

								last_slash);

		break;

	}



	case DSO_BINARY_TYPE__BUILDID_DEBUGINFO:

		if (!dso->has_build_id) {

			ret = -1;

tools/perf/util/dso.h

+1 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ enum dso_binary_type { 
	DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE,

	DSO_BINARY_TYPE__KCORE,

	DSO_BINARY_TYPE__GUEST_KCORE,

	DSO_BINARY_TYPE__OPENEMBEDDED_DEBUGINFO,

	DSO_BINARY_TYPE__NOT_FOUND,

};

tools/perf/util/symbol.c

+1 −0
Original line number Diff line number Diff line
@@ -51,6 +51,7 @@ static enum dso_binary_type binary_type_symtab[] = { 
	DSO_BINARY_TYPE__SYSTEM_PATH_DSO,

	DSO_BINARY_TYPE__GUEST_KMODULE,

	DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE,

	DSO_BINARY_TYPE__OPENEMBEDDED_DEBUGINFO,

	DSO_BINARY_TYPE__NOT_FOUND,

};