Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9c5f9c28 authored by Atsushi Nemoto's avatar Atsushi Nemoto Committed by David S. Miller
Browse files

isa-skelton: Remove a wrong netif_wake_queue() call 



The netif_wake_queue() is called correctly (i.e. only on !txfull
condition) from net_tx().  So Unconditional call to the
netif_wake_queue() here is wrong.  This might cause calling of
start_xmit routine on txfull state and trigger tx-ring overflow.

This fix is ported from commit 662a96bd
("tc35815: Remove a wrong netif_wake_queue() call which triggers BUG_ON").

Signed-off-by: default avatarAtsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fbc450b1

drivers/net/isa-skeleton.c

+0 −1
Original line number Diff line number Diff line
@@ -536,7 +536,6 @@ static irqreturn_t net_interrupt(int irq, void *dev_id) 
		/* Transmit complete. */

		net_tx(dev);

		np->stats.tx_packets++;

		netif_wake_queue(dev);

	}

#endif

	if (status & COUNTERS_INTR) {