Commit 9a523d42 authored Apr 27, 2009 by David Howells Committed by Linus Torvalds Apr 27, 2009

FRV: Stop gcc from generating uninitialised variable warnings after BUG()



Stop gcc from generating uninitialised variable warnings after BUG().
The problem is that FRV's call into its gdbstub appears to return (if
the function is marked noreturn, then the compiler is under no
obligation to pass it a return address, and so GDB won't know where the
bug happened).

To get around this, we make the do...while wrapper in _debug_bug_trap()
an endless loop from which there's no escape.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e37469f6

arch/frv/include/asm/bug.h

+3 −2

Original line number	Diff line number	Diff line
		@@ -30,7 +30,7 @@ extern void __debug_bug_printk(const char *file, unsigned line);
		do { \
		__debug_bug_trap(signr); \
		asm volatile("nop"); \
		} while(0)
		} while(1)

		#define HAVE_ARCH_BUG
		#define BUG() \
		@@ -46,7 +46,8 @@ do { \
		#define HAVE_ARCH_KGDB_BAD_PAGE
		#define kgdb_bad_page(page) do { kgdb_raise(SIGABRT); } while(0)
		#endif
		#endif

		#endif /* CONFIG_BUG */

		#include <asm-generic/bug.h>