Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a24b63d authored by Borislav Petkov's avatar Borislav Petkov Committed by Bartlomiej Zolnierkiewicz
Browse files

ide-floppy: disambiguate function names 



There were two almost identical function names in ide-floppy.c, which makes
their distinction almost impossible. While ide_floppy_release() cleans up the
object after the last reference to it has been dropped, idefloppy_release() is
the blkdev .release method from struct block_device_operations which releases
that last reference.

Rename ide_floppy_release() to idefloppy_cleanup_obj() in order to make its
purpose more clear.

There should be no functionality change resulting from this patch.

Signed-off-by: default avatarBorislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
parent 0078df2e

drivers/ide/ide-floppy.c

+3 −3
Original line number Diff line number Diff line
@@ -438,12 +438,12 @@ static struct ide_floppy_obj *ide_floppy_get(struct gendisk *disk) 
	return floppy;

}



static void ide_floppy_release(struct kref *);

static void idefloppy_cleanup_obj(struct kref *);



static void ide_floppy_put(struct ide_floppy_obj *floppy)

{

	mutex_lock(&idefloppy_ref_mutex);

	kref_put(&floppy->kref, ide_floppy_release);

	kref_put(&floppy->kref, idefloppy_cleanup_obj);

	mutex_unlock(&idefloppy_ref_mutex);

}
@@ -1713,7 +1713,7 @@ static void ide_floppy_remove(ide_drive_t *drive) 
	ide_floppy_put(floppy);

}



static void ide_floppy_release(struct kref *kref)

static void idefloppy_cleanup_obj(struct kref *kref)

{

	struct ide_floppy_obj *floppy = to_ide_floppy(kref);

	ide_drive_t *drive = floppy->drive;