Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 99dcb707 authored by Sachin Sant's avatar Sachin Sant Committed by Greg Kroah-Hartman
Browse files

selftest/powerpc: Fix false failures for skipped tests 




[ Upstream commit a6d8a21596df041f36f4c2ccc260c459e3e851f1 ]

Tests under alignment subdirectory are skipped when executed on previous
generation hardware, but harness still marks them as failed.

  test: test_copy_unaligned
  tags: git_version:unknown
  [SKIP] Test skipped on line 26
  skip: test_copy_unaligned
  selftests: copy_unaligned [FAIL]

The MAGIC_SKIP_RETURN_VALUE value assigned to rc variable is retained till
the program exit which causes the test to be marked as failed.

This patch resets the value before returning to the main() routine.
With this patch the test o/p is as follows:

  test: test_copy_unaligned
  tags: git_version:unknown
  [SKIP] Test skipped on line 26
  skip: test_copy_unaligned
  selftests: copy_unaligned [PASS]

Signed-off-by: default avatarSachin Sant <sachinp@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ab1d27b5

tools/testing/selftests/powerpc/harness.c

+4 −2
Original line number Diff line number Diff line
@@ -105,9 +105,11 @@ int test_harness(int (test_function)(void), char *name) 


	rc = run_test(test_function, name);



	if (rc == MAGIC_SKIP_RETURN_VALUE)

	if (rc == MAGIC_SKIP_RETURN_VALUE) {

		test_skip(name);

	else

		/* so that skipped test is not marked as failed */

		rc = 0;

	} else

		test_finish(name, rc);



	return rc;