Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9915e67e authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

drivers/net/irda: fix error return code 

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret;
expression e1,e2;
@@

if (ret < 0)
 { ... return ret; }
 ... when != ret = e1
     when forall
*if(...)
 {
  ... when != ret = e2
* return ret;
 }
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 623d896b

drivers/net/irda/ks959-sir.c

+1 −0
Original line number Diff line number Diff line
@@ -542,6 +542,7 @@ static int ks959_net_open(struct net_device *netdev) 
	sprintf(hwname, "usb#%d", kingsun->usbdev->devnum);

	kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname);

	if (!kingsun->irlap) {

		err = -ENOMEM;

		dev_err(&kingsun->usbdev->dev, "irlap_open failed\n");

		goto free_mem;

	}

drivers/net/irda/ksdazzle-sir.c

+1 −0
Original line number Diff line number Diff line
@@ -436,6 +436,7 @@ static int ksdazzle_net_open(struct net_device *netdev) 
	sprintf(hwname, "usb#%d", kingsun->usbdev->devnum);

	kingsun->irlap = irlap_open(netdev, &kingsun->qos, hwname);

	if (!kingsun->irlap) {

		err = -ENOMEM;

		dev_err(&kingsun->usbdev->dev, "irlap_open failed\n");

		goto free_mem;

	}