Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98ec1878 authored by Jason Wessel's avatar Jason Wessel
Browse files

kgdb: remove post_primary_code references 



Remove all the references to the kgdb_post_primary_code.  This
function serves no useful purpose because you can obtain the same
information from the "struct kgdb_state *ks" from with in the
debugger, if for some reason you want the data.

Also remove the unintentional duplicate assignment for ks->ex_vector.

Signed-off-by: default avatarJason Wessel <jason.wessel@windriver.com>
parent 84c08fd6

arch/x86/kernel/kgdb.c

+0 −29
Original line number Diff line number Diff line
@@ -47,20 +47,8 @@ 
#include <asm/debugreg.h>

#include <asm/apicdef.h>

#include <asm/system.h>



#include <asm/apic.h>



/*

 * Put the error code here just in case the user cares:

 */

static int gdb_x86errcode;



/*

 * Likewise, the vector number here (since GDB only gets the signal

 * number through the usual means, and that's not very specific):

 */

static int gdb_x86vector = -1;



/**

 *	pt_regs_to_gdb_regs - Convert ptrace regs to GDB regs

 *	@gdb_regs: A pointer to hold the registers in the order GDB wants.
@@ -399,23 +387,6 @@ void kgdb_disable_hw_debug(struct pt_regs *regs) 
	}

}



/**

 *	kgdb_post_primary_code - Save error vector/code numbers.

 *	@regs: Original pt_regs.

 *	@e_vector: Original error vector.

 *	@err_code: Original error code.

 *

 *	This is needed on architectures which support SMP and KGDB.

 *	This function is called after all the slave cpus have been put

 *	to a know spin state and the primary CPU has control over KGDB.

 */

void kgdb_post_primary_code(struct pt_regs *regs, int e_vector, int err_code)

{

	/* primary processor is completely in the debugger */

	gdb_x86vector = e_vector;

	gdb_x86errcode = err_code;

}



#ifdef CONFIG_SMP

/**

 *	kgdb_roundup_cpus - Get other CPUs into a holding pattern

include/linux/kgdb.h

+0 −14
Original line number Diff line number Diff line
@@ -35,20 +35,6 @@ struct pt_regs; 
 */

extern int kgdb_skipexception(int exception, struct pt_regs *regs);



/**

 *	kgdb_post_primary_code - (optional) Save error vector/code numbers.

 *	@regs: Original pt_regs.

 *	@e_vector: Original error vector.

 *	@err_code: Original error code.

 *

 *	This is usually needed on architectures which support SMP and

 *	KGDB.  This function is called after all the secondary cpus have

 *	been put to a know spin state and the primary CPU has control over

 *	KGDB.

 */

extern void kgdb_post_primary_code(struct pt_regs *regs, int e_vector,

				  int err_code);



/**

 *	kgdb_disable_hw_debug - (optional) Disable hardware debugging hook

 *	@regs: Current &struct pt_regs.

kernel/debug/debug_core.c

+0 −8
Original line number Diff line number Diff line
@@ -203,12 +203,6 @@ int __weak kgdb_skipexception(int exception, struct pt_regs *regs) 
	return 0;

}



void __weak

kgdb_post_primary_code(struct pt_regs *regs, int e_vector, int err_code)

{

	return;

}



/**

 *	kgdb_disable_hw_debug - Disable hardware debugging while we in kgdb.

 *	@regs: Current &struct pt_regs.
@@ -588,7 +582,6 @@ return_normal: 
	 * At this point the primary processor is completely

	 * in the debugger and all secondary CPUs are quiescent

	 */

	kgdb_post_primary_code(ks->linux_regs, ks->ex_vector, ks->err_code);

	dbg_deactivate_sw_breakpoints();

	kgdb_single_step = 0;

	kgdb_contthread = current;
@@ -678,7 +671,6 @@ kgdb_handle_exception(int evector, int signo, int ecode, struct pt_regs *regs) 
	ks->cpu			= raw_smp_processor_id();

	ks->ex_vector		= evector;

	ks->signo		= signo;

	ks->ex_vector		= evector;

	ks->err_code		= ecode;

	ks->kgdb_usethreadid	= 0;

	ks->linux_regs		= regs;